Skip to content

chore(tests): address integration test flakiness #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 4, 2023

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Sep 3, 2023

Description of your changes

In #1661 we have made changes to the integration test and as a result we inadvertently introduced some flakiness. This PR addresses this by applying the following fixes:

  • reviewed & made unique all the test suffix across utilities
  • introduce runtime key in SSM secret string name/path
  • revisited X-Ray trace retrieval and moved to using function name instead of ARN
  • unified workflow to use single job

Related issues, RFCs

Issue number: #1668

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Sep 3, 2023
@dreamorosi dreamorosi requested a review from a team September 3, 2023 15:07
@dreamorosi dreamorosi linked an issue Sep 3, 2023 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added automation This item relates to automation layers Items related to the Lambda Layers pipeline dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Sep 3, 2023
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Sep 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Sep 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
40.1% 40.1% Duplication

@dreamorosi dreamorosi merged commit f3916d1 into main Sep 4, 2023
@dreamorosi dreamorosi deleted the chore/test_flakyness branch September 4, 2023 08:40
@github-actions

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. do-not-merge This item should not be merged layers Items related to the Lambda Layers pipeline need-issue This PR needs an issue before it can be reviewed/worked on further size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: address integration test flakiness
1 participant